birth-software/bloat-buster
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rework open permissions

Browse Source
This commit is contained in:
David Gonzalez Martin 2024-10-09 10:04:48 -06:00 committed by David
parent 6faf9f46a8
commit 5d2bb2218e
2 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
bootstrap/lib.h
View File

@ -1600,6 +1600,13 @@ STRUCT(OSFileOpenFlags)
u32 create:1; u32 create:1;
}; };
STRUCT(OSFilePermissions)
{
u8 readable:1;
u8 writable:1;
u8 executable:1;
};
may_be_unused fn u8 os_file_descriptor_is_valid(FileDescriptor fd) may_be_unused fn u8 os_file_descriptor_is_valid(FileDescriptor fd)
{ {
#if _WIN32 #if _WIN32
@ -1609,15 +1616,15 @@ may_be_unused fn u8 os_file_descriptor_is_valid(FileDescriptor fd)
#endif #endif
} }
may_be_unused fn FileDescriptor os_file_open(String path, OSFileOpenFlags flags) may_be_unused fn FileDescriptor os_file_open(String path, OSFileOpenFlags flags, OSFilePermissions permissions)
{ {
assert(path.pointer[path.length] == 0); assert(path.pointer[path.length] == 0);
#if _WIN32 #if _WIN32
DWORD dwDesiredAccess = 0; DWORD dwDesiredAccess = 0;
dwDesiredAccess |= flags.read * GENERIC_READ; dwDesiredAccess |= permissions.readable * GENERIC_READ;
dwDesiredAccess |= flags.write * GENERIC_WRITE; dwDesiredAccess |= permissions.writable * GENERIC_WRITE;
dwDesiredAccess |= flags.write * GENERIC_EXECUTE; dwDesiredAccess |= permissions.executable * GENERIC_EXECUTE;
DWORD dwShareMode = 0; DWORD dwShareMode = 0;
LPSECURITY_ATTRIBUTES lpSecurityAttributes = 0; LPSECURITY_ATTRIBUTES lpSecurityAttributes = 0;
DWORD dwCreationDisposition = 0; DWORD dwCreationDisposition = 0;
@ -1636,16 +1643,17 @@ may_be_unused fn FileDescriptor os_file_open(String path, OSFileOpenFlags flags)
posix_flags |= O_CREAT * flags.create; posix_flags |= O_CREAT * flags.create;
posix_flags |= O_TRUNC * flags.truncate; posix_flags |= O_TRUNC * flags.truncate;
int permissions; int posix_permissions;
if (flags.executable && flags.write) // TODO: make permissions better
if (permissions.executable)
{ {
permissions = 0755; posix_permissions = 0755;
} }
else else
{ {
permissions = 0644; posix_permissions = 0644;
} }
auto result = syscall_open((char*)path.pointer, posix_flags, permissions); auto result = syscall_open((char*)path.pointer, posix_flags, posix_permissions);
return result; return result;
#endif #endif
} }
@ -3184,6 +3192,8 @@ fn String file_read(Arena* arena, String path)
.write = 0, .write = 0,
.read = 1, .read = 1,
.create = 0, .create = 0,
}, (OSFilePermissions) {
.readable = 1,
}); });
if (os_file_descriptor_is_valid(file_descriptor)) if (os_file_descriptor_is_valid(file_descriptor))

4
bootstrap/main.c
View File

@ -14610,6 +14610,10 @@ fn void code_generation(Thread* restrict thread, CodegenOptions options)
.truncate = 1, .truncate = 1,
.create = 1, .create = 1,
.executable = 1, .executable = 1,
}, (OSFilePermissions) {
.readable = 1,
.writable = 1,
.executable = 1,
}); });
#if _WIN32 #if _WIN32
if (!os_file_descriptor_is_valid(fd)) if (!os_file_descriptor_is_valid(fd))