birth-software/nativity
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #189 from birth-software/add-sleep-in-hot-thread-loop

Browse Source 
Add sleep calls in hot thread loop
This commit is contained in:
David 2024-05-23 20:22:36 -06:00 committed by GitHub
commit 8713de03d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bootstrap/compiler.zig
View File

@ -1227,11 +1227,14 @@ const Unit = struct {
fn control_thread(unit: *Unit) void { fn control_thread(unit: *Unit) void {
var last_assigned_thread_index: u32 = 1; var last_assigned_thread_index: u32 = 1;
var first_ir_done = false; var first_ir_done = false;
var total_is_done: bool = false; var total_is_done: bool = false;
var iterations_without_work_done: u32 = 0;
while (!total_is_done) { while (!total_is_done) {
total_is_done = first_ir_done; total_is_done = first_ir_done;
var task_done_this_iteration: u32 = 0;
for (instance.threads, 0..) |*thread, i| { for (instance.threads, 0..) |*thread, i| {
// INFO: No need to do an atomic load here since it's only this thread writing to the value // INFO: No need to do an atomic load here since it's only this thread writing to the value
const program_state = thread.task_system.program_state; const program_state = thread.task_system.program_state;
@ -1300,8 +1303,15 @@ fn control_thread(unit: *Unit) void {
thread.task_system.ask.complete_job(); thread.task_system.ask.complete_job();
previous_job = job; previous_job = job;
task_done_this_iteration += 1;
} }
} }
iterations_without_work_done += @intFromBool(task_done_this_iteration == 0);
if (iterations_without_work_done > 5) {
std.time.sleep(100);
}
} }
var objects = PinnedArray([]const u8){}; var objects = PinnedArray([]const u8){};
@ -1762,7 +1772,7 @@ fn worker_thread(thread_index: u32, cpu_count: *u32) void {
const file_index = job.count; const file_index = job.count;
const file = &instance.files.pointer[file_index]; const file = &instance.files.pointer[file_index];
if (&instance.threads[file.thread] == thread) { if (thread == &instance.threads[file.thread]) {
exit_with_error("Threads match!"); exit_with_error("Threads match!");
} else { } else {
const file_path_hash = job.offset; const file_path_hash = job.offset;
@ -2084,6 +2094,7 @@ fn worker_thread(thread_index: u32, cpu_count: *u32) void {
assert(thread.task_system.job.worker.completed == c + 1); assert(thread.task_system.job.worker.completed == c + 1);
} }
std.time.sleep(1000);
std.atomic.spinLoopHint(); std.atomic.spinLoopHint();
} }
} }